Merged
Conversation
Borda
force-pushed
the
pyupgrade
branch
3 times, most recently
from
ef11b09 to
3e5dc92
Compare
Signed-off-by: Jirka <[email protected]>
wyli
reviewed
Sep 25, 2021
Contributor
There was a problem hiding this comment.
I guess the goal is to do this kind of commit automatically in the future, not sure whether it is compatible with the other code formatting tools. But the current changes look good. We can experiment it with the development branch for a while first
Signed-off-by: Jirka <[email protected]>
Contributor
Author
it shall be and another case it shall be caught by your CI :] |
Contributor
|
/integration-test |
wyli
approved these changes
Sep 25, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
It looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Python notation to be better suitable to python 3.6+
in fact, I have just used the
pyupgradenook in pre-commitStatus
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.