Fix reduction=none for Dice and Focal loss#3025
Closed
Erotemic wants to merge 4 commits intoProject-MONAI:devfrom
Closed
Fix reduction=none for Dice and Focal loss#3025Erotemic wants to merge 4 commits intoProject-MONAI:devfrom
Erotemic wants to merge 4 commits intoProject-MONAI:devfrom
Conversation
7 tasks
Erotemic
force-pushed
the
fix_loss_no_reduction
branch
from
bbd5b1c to
938f457
Compare
Contributor
|
closing this in favour of #3041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP. There seems to be an issue with focal and Dice loss when reduction=None. I want to be 100% sure I've got it right before I get a review.
I'm pretty sure at least the focal loss variant is correct. I'm less certain about dices. Pushing this up so I don't lose it.