Skip to content

dimension check for pretrained model weights#2984

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
neuronflow:patch-1
Sep 21, 2021
Merged

dimension check for pretrained model weights#2984
wyli merged 4 commits intoProject-MONAI:devfrom
neuronflow:patch-1

Conversation

@neuronflow
Copy link
Copy Markdown
Contributor

@neuronflow neuronflow commented Sep 20, 2021 •
edited
Loading

This PR implements a dimension check, before trying to load pre-trained model weights.

Fixes # .

Description

This PR implements a dimension check, before trying to load pre-trained model weights.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 20, 2021

thanks for the PR! could you please sign: https://github.com/Project-MONAI/MONAI/pull/2984/checks?check_run_id=3656576890 (https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work)

@neuronflow
Copy link
Copy Markdown
Contributor Author

neuronflow commented Sep 20, 2021

sure, trying to find out how to do this in hindsight now :) I made the PR with the github web editor as it is so small.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 20, 2021 •
edited
Loading

/black
/build

neuronflow and others added 2 commits September 21, 2021 01:50
@neuronflow
dimension check for pretrained model weights
1bd5c97 
This PR implements a dimension check, before trying to load pre-trained model weights.

Signed-off-by: neuronflow <[email protected]>
@monai-bot @neuronflow
[MONAI] python code formatting
ad629d1 
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: neuronflow <[email protected]>
@neuronflow
Copy link
Copy Markdown
Contributor Author

neuronflow commented Sep 21, 2021 •
edited
Loading

Okay I hope I managed to fix it..also tests seem to pass locally. Your build pipeline this whole integration process is very cool!

wyli
wyli approved these changes Sep 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the DCO looks good now, there is a minor style issue https://github.com/Project-MONAI/MONAI/pull/2984/checks?check_run_id=3663404181#step:7:116

@neuronflow
Copy link
Copy Markdown
Contributor Author

neuronflow commented Sep 21, 2021 

/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:311:151: B950 line too long (150 > 120 characters)
/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:337:151: B950 line too long (150 > 120 characters)
/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:363:151: B950 line too long (150 > 120 characters)
3     B950 line too long (150 > 120 characters)
3
Check failed!
Please run auto style fixes: ./runtests.sh --autofix
Error: Process completed with exit code 1.

@wyli
Hmm I did run the autofix and also monaibot would set the line length to 150. Could it be that there is a difference in settings for the automatic linting applied by @monai-bot and the test?

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 21, 2021

I think in this case the bot doesn't know how to break the long line, it has to be done manually at the moment...

@wyli wyli enabled auto-merge (squash) September 21, 2021 17:42
@wyli wyli merged commit f31b55f into Project-MONAI:dev Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neuronflow @wyli @monai-bot