Torch GaussianSmooth, RandGaussianSmooth, GaussianSharpen, RandGaussianSharpen#2971
Merged
rijobro merged 9 commits intoProject-MONAI:devfrom Sep 24, 2021
Merged
Conversation
…dGaussianSharpen` Signed-off-by: Richard Brown <[email protected]>
Contributor
|
Hi @rijobro , I am checking the left transforms, seems these 4 intensity transforms already execute with Tensor data, but the code stype doesn't follow our backend design: Thanks in advance. |
Contributor
Author
|
Sure, I'll do them on Monday. |
wyli
reviewed
Sep 20, 2021
wyli
reviewed
Sep 20, 2021
Contributor
Author
|
hi @wyli I'm struggling to replicate the problems in this PR locally. I've tried with pytorch 1.6 and 1.7, with cuda toolkit 11.0 and 10.2, to no avail. Any ideas? https://github.com/Project-MONAI/MONAI/pull/2971/checks?check_run_id=3673884529 Edit: managed to replicate, thanks. |
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
wyli
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Torch
GaussianSmooth,RandGaussianSmooth,GaussianSharpen,RandGaussianSharpenStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.