Skip to content

enhance affinegrid to use torch backend#2969

Merged
wyli merged 23 commits intoProject-MONAI:devfrom
wyli:tensor-affine-grid
Sep 20, 2021
Merged

enhance affinegrid to use torch backend#2969
wyli merged 23 commits intoProject-MONAI:devfrom
wyli:tensor-affine-grid

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Sep 17, 2021 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

part of #2231

Description

  • enhancing AffineGrid and the utilities
  • enhancing spatial cropping xforms

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the tensor-affine-grid branch from 11f0261 to fe663ab Compare September 17, 2021 16:26
wyli added 12 commits September 17, 2021 17:37
@wyli
backend affien grid
e2fa593 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Merge branch 'dev' into tensor-affine-grid
7b049b0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
device support
fa99300 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
less lookup
a0ee97d 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
create grid with torch backend
7171eb1 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes tests
7c8808b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Merge remote-tracking branch 'upstream/dev' into affine-grid-device
767ee57 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
default to torch create grid
9818833 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes unit test
0c700f9 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
randaffine with create grid
6ca3ae7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
create_grid backend change for spatial transforms
125dcec 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
create control grid tensor
f4b6da4 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the tensor-affine-grid branch from d14cc77 to f4b6da4 Compare September 19, 2021 14:31
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 19, 2021 •
edited
Loading

/black
/integration-test

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 19, 2021

/build

@wyli
enhance spatial, and crop xforms
2f1078f 
  - Update test_rand_deform_grid.py
  - center_scale_crop
  - center_spatial_crop
  - rand_scale_crop
  - rand_spatial_crop
  - rand_spatial_crop_samples

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the tensor-affine-grid branch from 2f95492 to 2f1078f Compare September 19, 2021 22:49
wyli added 5 commits September 20, 2021 00:22
@wyli
fixes invert
e72f5d2 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
tensor resize, unit test fixes
d9b6b6b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
unit test fix
b2773ca 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes codeformat
e7d6281 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
resize_with_pad_or_crop
218058b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review September 20, 2021 06:55
@wyli
fixes mypy issue
54c5f0b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 20, 2021

Hi @Nic-Ma @rijobro, I went through the transforms/croppad and transforms/spatial modules since your previous review , added non-breaking changes and tests. Please let me know if you find any issues. I'll merge this and tag a release candidate to run more tests.

@wyli wyli enabled auto-merge (squash) September 20, 2021 07:47
@wyli wyli merged commit ee202fa into Project-MONAI:dev Sep 20, 2021
@wyli wyli deleted the tensor-affine-grid branch September 20, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro rijobro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyli @Nic-Ma @rijobro