Skip to content

Fix float64 issue in MedNIST test#2941

Merged
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:fix-float64-issue
Sep 13, 2021
Merged

Fix float64 issue in MedNIST test#2941
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:fix-float64-issue

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Sep 13, 2021

Fixes Project-MONAI/tutorials#349

Description

This PR fixed the issue that input int and output float64 when scaling.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Sep 13, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli September 13, 2021 14:38
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a non-breaking change

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 13, 2021 15:02
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 13, 2021

/build

@Nic-Ma Nic-Ma merged commit 8651b62 into Project-MONAI:dev Sep 13, 2021
wyli pushed a commit to rijobro/MONAI that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly test error -- ./modules/mednist_GAN_workflow_array.ipynb

3 participants