Skip to content

2901 ndim -> spatial_dims#2903

Merged
wyli merged 10 commits intoProject-MONAI:devfrom
wyli:2901-deprecate-dimensions
Sep 8, 2021
Merged

2901 ndim -> spatial_dims#2903
wyli merged 10 commits intoProject-MONAI:devfrom
wyli:2901-deprecate-dimensions

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Sep 6, 2021 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #2901

Description

  • deprecate ndim
  • enhance deprecated_arg

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the 2901-deprecate-dimensions branch from 9872fb0 to a9d9bb2 Compare September 6, 2021 17:14
@wyli wyli marked this pull request as ready for review September 6, 2021 18:42
Nic-Ma
Nic-Ma reviewed Sep 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Thanks for your quick update.
I want to confirm the expected behavior: It will print deprecated warning at 0.7? And will print error at 0.8?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 7, 2021

Hi @wyli ,

Thanks for your quick update.
I want to confirm the expected behavior: It will print deprecated warning at 0.7? And will print error at 0.8?

Thanks.

It will only print warnings in the current implementation. we'll need another PR to remove the parameters when we decide they are no longer supported. I think we can remove the deprecated APIs before 1.0.

@wyli wyli marked this pull request as draft September 7, 2021 07:43
@wyli wyli force-pushed the 2901-deprecate-dimensions branch from a427d60 to efb6a1a Compare September 7, 2021 13:29
@wyli
ndim -> spatial_dims
c778215 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 2901-deprecate-dimensions branch from efb6a1a to 248276e Compare September 7, 2021 13:30
@wyli wyli force-pushed the 2901-deprecate-dimensions branch from 248276e to 9bbab99 Compare September 7, 2021 13:34
Nic-Ma
Nic-Ma approved these changes Sep 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@yiheng-wang-nv Could you please help double confirm all the network updating tomorrow before merging it?

Thanks in advance.

wyli
wyli commented Sep 7, 2021
View reviewed changes
@wyli wyli marked this pull request as ready for review September 7, 2021 16:09
@wyli wyli force-pushed the 2901-deprecate-dimensions branch from eff7a62 to 973c297 Compare September 7, 2021 17:10
wyli added 2 commits September 7, 2021 18:54
@wyli
fixes typo
82d5fb8 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
resolves refs/pull versions
661159b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 7, 2021

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 7, 2021

/integration-test

@wyli wyli merged commit 7cfc8ea into Project-MONAI:dev Sep 8, 2021
@wyli wyli deleted the 2901-deprecate-dimensions branch September 8, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

+1 more reviewer

@Borda Borda Borda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

consistent parameter dimensions spatial_dims

3 participants

@wyli @Borda @Nic-Ma