Merged
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
wyli
approved these changes
Aug 24, 2021
Contributor
|
/build |
Signed-off-by: Behrooz <[email protected]>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the methods for
nn.Moduletoforwardonly. The reason is that__call__finally callsforwardand the overhead is insignificant in the tests that I have done, so annotating both create redundancy and make the output less readable.It also drops the logic to annotate
DataLoaderssince their iterator is being created in the runtime and there is not any obvious way to annotate them. Instead, one can annotateDataset.Status
Ready
Types of changes