NVTX Range universal decorator#2814
Merged
wyli merged 23 commits intoProject-MONAI:devfrom Aug 24, 2021
Merged
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Contributor
|
/build |
wyli
reviewed
Aug 21, 2021
wyli
approved these changes
Aug 23, 2021
Contributor
wyli
left a comment
There was a problem hiding this comment.
thank you, please resolve the conversation then I'll trigger the tests and merge
Signed-off-by: Behrooz <[email protected]>
Contributor
|
/build |
Signed-off-by: Behrooz <[email protected]>
Contributor
|
/build |
Member
Author
|
Wait a moment. I'm doing minor changes. |
Signed-off-by: Behrooz <[email protected]>
Member
Author
|
/build |
Contributor
|
/build |
Member
Author
Contributor
|
it's #2821 according to the logs, I try to reproduce locally but it's not easy |
Contributor
|
/build |
Member
Author
|
/build |
1 similar comment
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Rangewhich is both a decorator and a context manager for adding NVTX range to most of the MONAI components. It decorates the appropriate method of MONAI components objects such as transfoms, networks, losses, etc.It also can be used with
withruntime context to annotate an arbitrary part of the code.This PR also removes
Rangetransform in favor ofRangedecorator to have only one way of doing this. However, the rest of NVTX transforms (Mark,RangePush,RangePop) still have their own use.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.