Skip to content

2805 CropForegroundd supports different modes for keys#2808

Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2805-enhance-crop-mode
Aug 20, 2021
Merged

2805 CropForegroundd supports different modes for keys#2808
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2805-enhance-crop-mode

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Aug 19, 2021

Fixes #2805 .

Description

This PR enhanced the CropForegroundd transform to support different padding mode for different keys.
This is a feature request from Dong.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Aug 19, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli August 19, 2021 12:40
@Nic-Ma Nic-Ma enabled auto-merge (squash) August 19, 2021 14:12
@Nic-Ma Nic-Ma merged commit 2c7ec57 into Project-MONAI:dev Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CropForegroundd need to support different modes for keys

3 participants