Skip to content

2771 HighResBlock convolution#2793

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:2771-fixes-highresblock
Aug 17, 2021
Merged

2771 HighResBlock convolution#2793
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:2771-fixes-highresblock

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Aug 17, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2771

Description

this removes the redundant activations after the convolution.
it will break the previously trained models.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from yiheng-wang-nv August 17, 2021 08:11
@wyli wyli changed the title fixes #2771 HighResBlock convolution 2771 HighResBlock convolution Aug 17, 2021
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wyli wyli enabled auto-merge (squash) August 17, 2021 09:00
@wyli wyli merged commit dea3f70 into Project-MONAI:dev Aug 17, 2021
@wyli wyli deleted the 2771-fixes-highresblock branch October 4, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HighResBlock may have wrong conv block

2 participants