Skip to content

Add NVTX handlers#2765

Merged
wyli merged 24 commits intoProject-MONAI:devfrom
bhashemian:nvtx-handlers
Aug 17, 2021
Merged

Add NVTX handlers#2765
wyli merged 24 commits intoProject-MONAI:devfrom
bhashemian:nvtx-handlers

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Aug 13, 2021 •
edited
Loading

Fixes #2764

Description

This PR adds NVTX handlers to enable probing and profiling MONAI workflow through Ignite events. It attached nvtx marks and ranges to Ignite events.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian marked this pull request as ready for review August 13, 2021 18:06
@bhashemian bhashemian mentioned this pull request Aug 13, 2021
Merged
@bhashemian bhashemian requested review from Nic-Ma and wyli August 13, 2021 18:18
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Aug 13, 2021

@Nic-Ma @wyli , I also have updated the tutorial to include this handlers to trace iteration time (ITERATION_STARTED, ITERATION_COMPLETED) and batch preparation time (GET_BATCH_STARTED, GET_BATCH_COMPLETED). Project-MONAI/tutorials#310

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Aug 16, 2021

@Nic-Ma @wyli, I'd appreciate your review here. Thanks

@bhashemian bhashemian mentioned this pull request Aug 16, 2021
Closed
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Aug 16, 2021

#2728

Nic-Ma
Nic-Ma reviewed Aug 16, 2021
View reviewed changes
Nic-Ma
Nic-Ma approved these changes Aug 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
PR looks good to me now, @wyli could you please help also review it?

Thanks.

wyli
wyli reviewed Aug 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks good to me

@bhashemian bhashemian enabled auto-merge (squash) August 17, 2021 13:31
@wyli wyli disabled auto-merge August 17, 2021 21:50
@wyli wyli enabled auto-merge (squash) August 17, 2021 21:50
@wyli wyli merged commit 46d5f2a into Project-MONAI:dev Aug 17, 2021
@bhashemian bhashemian deleted the nvtx-handlers branch August 18, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Performance enhancements 0.7.0

Development

Successfully merging this pull request may close these issues.

NVTX handlers to probe workflow

3 participants

@bhashemian @wyli @Nic-Ma