Skip to content

Update Mish to default PyTorch 1.9 version#2733

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
digantamisra98:patch-1
Aug 11, 2021
Merged

Update Mish to default PyTorch 1.9 version#2733
wyli merged 6 commits intoProject-MONAI:devfrom
digantamisra98:patch-1

Conversation

@digantamisra98
Copy link
Copy Markdown
Contributor

@digantamisra98 digantamisra98 commented Aug 9, 2021

Description

Update Mish to use the default in PyTorch 1.9

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Aug 9, 2021

Hi @digantamisra98 ,

Thanks for your contribution here.
I think you can use some existing MONAI utilises to simplify:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/utils/module.py#L362

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 10, 2021

/black

@wyli wyli enabled auto-merge (squash) August 10, 2021 18:46
@digantamisra98
Copy link
Copy Markdown
Contributor Author

@Nic-Ma Sorry checked back on this late, looks like @wyli has addressed the changes. Thanks a ton for the same.

@madil90
Copy link
Copy Markdown
Contributor

madil90 commented Aug 11, 2021

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli disabled auto-merge August 11, 2021 08:24
@wyli wyli enabled auto-merge (squash) August 11, 2021 08:24
@wyli wyli merged commit 33184fa into Project-MONAI:dev Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants