2679 Add IntensityStats transform to record intensity statistics into meta data#2685
Merged
Nic-Ma merged 21 commits intoProject-MONAI:devfrom Aug 4, 2021
Merged
2679 Add IntensityStats transform to record intensity statistics into meta data#2685Nic-Ma merged 21 commits intoProject-MONAI:devfrom
Nic-Ma merged 21 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
changed the title
Contributor
Author
|
I enhanced Thanks. |
Signed-off-by: Nic Ma <[email protected]>
wyli
reviewed
Aug 3, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, I put some comments inline
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
2679-intensitystats
branch
from
d752ea4 to
0a89470
Compare
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @wyli , Thanks for your review. Thanks in advance. |
Signed-off-by: Nic Ma <[email protected]>
wyli
reviewed
Aug 3, 2021
Signed-off-by: Nic Ma <[email protected]>
wyli
approved these changes
Aug 3, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, would be great to have the pickle example as a unit test, but I think it's beyond this PR.
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @wyli , I found an easy way to test the pickle issue, already added the logic in the unit test in the latest commit. Thanks. |
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2679 .
Description
This PR added
IntensityStatstransform to record intensity statistics into meta data for other following transforms to dynamically adjust parameters for every image.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.