2627 Enhance surface metrics warning#2638
Merged
Nic-Ma merged 5 commits intoProject-MONAI:devfrom Jul 21, 2021
Merged
Conversation
Contributor
Author
|
/black |
yiheng-wang-nv
approved these changes
Jul 21, 2021
Contributor
yiheng-wang-nv
left a comment
yiheng-wang-nv
left a comment
There was a problem hiding this comment.
Thanks, I think this change is better than the original implementation to avoid "duplicated" warnings when directed == False for HausdorffDistanceMetric
Contributor
Author
|
Hi @yiheng-wang-nv , Thanks for your review. Thanks. |
Contributor
|
/build |
rijobro
added a commit
that referenced
this pull request
Jul 22, 2021
* 2630 adds look_up_option (#2631) * adds look_up_options Signed-off-by: Wenqi Li <[email protected]> * adds docstring example Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]> * update enum look ups Signed-off-by: Wenqi Li <[email protected]> * fixes typos Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * [DLMED] enhance distance metrics warning (#2638) Signed-off-by: Nic Ma <[email protected]> * randweightedcrop (partially done) Signed-off-by: Richard Brown <[email protected]> * fixes Pad type hint Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Nic Ma <[email protected]> Co-authored-by: Richard Brown <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2627 .
Description
This PR enhanced the confusing warning messages of distance metrics.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.