Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
2630-utility-look-up
branch
from
589e90b to
d121f8f
Compare
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
2630-utility-look-up
branch
from
d121f8f to
ce97dc1
Compare
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
2630-utility-look-up
branch
from
0e0e439 to
05bee86
Compare
Nic-Ma
approved these changes
Jul 20, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the enhancement, I put some minor comments inline.
Others look good to me.
@ericspod could you please help double confirm the implementation of damerau_levenshtein_distance? It looks good to me but I am not sure whether it's the best practice, I remember there are many different implementation methods with different drawbacks when I was working on NLP project.
Thanks.
wyli
force-pushed
the
2630-utility-look-up
branch
from
2269c0d to
22a60aa
Compare
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
2630-utility-look-up
branch
from
22a60aa to
2e9400f
Compare
7 tasks
rijobro
added a commit
that referenced
this pull request
Jul 22, 2021
* 2630 adds look_up_option (#2631) * adds look_up_options Signed-off-by: Wenqi Li <[email protected]> * adds docstring example Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]> * update enum look ups Signed-off-by: Wenqi Li <[email protected]> * fixes typos Signed-off-by: Wenqi Li <[email protected]> * update based on comments Signed-off-by: Wenqi Li <[email protected]> * [DLMED] enhance distance metrics warning (#2638) Signed-off-by: Nic Ma <[email protected]> * randweightedcrop (partially done) Signed-off-by: Richard Brown <[email protected]> * fixes Pad type hint Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Nic Ma <[email protected]> Co-authored-by: Richard Brown <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #2630
Description
Status
Ready
Types of changes
KeyErrortoValueError./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.