Skip to content

2617 fix synthetic bugs#2621

Merged
ericspod merged 5 commits intoProject-MONAI:devfrom
yiheng-wang-nv:2617-fix-create-test-image
Jul 19, 2021
Merged

2617 fix synthetic bugs#2621
ericspod merged 5 commits intoProject-MONAI:devfrom
yiheng-wang-nv:2617-fix-create-test-image

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jul 16, 2021 •
edited
Loading

Signed-off-by: Yiheng Wang [email protected]

Fixes #2617 .

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv
fix synthetic bugs
f672d7a 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
add unittest
a3f0695 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli July 16, 2021 16:42
@wyli wyli requested a review from ericspod July 19, 2021 08:41
@ericspod
Copy link
Copy Markdown
Member

ericspod commented Jul 19, 2021

There's a few places in monai/tests/utils.py where the creation functions are used, the arguments provided to them need to be adjusted. Also the plural of radius is radii, that's Latin for you!

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Jul 19, 2021

There's a few places in monai/tests/utils.py where the creation functions are used, the arguments provided to them need to be adjusted. Also the plural of radius is radii, that's Latin for you!

Thanks @ericspod , I adjusted those affected test functIons. Could you please help to re-review this PR?

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 19, 2021

/integration-test

@ericspod ericspod merged commit c1d2617 into Project-MONAI:dev Jul 19, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the 2617-fix-create-test-image branch July 20, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@wyli wyli Awaiting requested review from wyli

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bugs in create_test_image_2d and create_test_image_3d

3 participants

@yiheng-wang-nv @ericspod @wyli