/black

/integration-test

Hi @Nic-Ma, there's a change conflict here in case you didn't see it

/black

Hi @wyli ,

Seems our PyTorch 1.7 CI test is not running with official PyTorch 1.7(our version is 1.7.0a0+8deb4fe)?
There is no set_to_none arg in it.

Thanks.

Hi @wyli ,

Should I change this line to use PyTorch 1.7.1 version instead?
https://github.com/Project-MONAI/MONAI/blob/dev/.github/workflows/pythonapp.yml#L224
Maybe let me change all the other items to install explicit PyTorch version instead of the PyTorch in the docker?

Thanks.

Hi @wyli ,

Should I change this line to use PyTorch 1.7.1 version instead?
https://github.com/Project-MONAI/MONAI/blob/dev/.github/workflows/pythonapp.yml#L224

Thanks.

that is supposed to test nvidia's pytorch docker image, changing that is a separate topic.
Now this PR doesn't work with pytorch:20.09, maybe we can change the code to fix it... perhaps get_torch_version_tuple() <= (1, 7)?

Hi @wyli ,

I want to double confirm the root cause is that the docker customized PyTorch 1.6 to make a 1.7a version in it, right?
If we change to <=1.7, users with PyTorch 1.7.0 can't use this feature anymore:
https://github.com/pytorch/pytorch/blob/v1.7.0/torch/optim/optimizer.py#L167
But maybe not a big problem?

Thanks.

Hi @wyli ,

I want to double confirm the root cause is that the docker customized PyTorch 1.6 to make a 1.7a version in it, right?
If we change to <=1.7, users with PyTorch 1.7.0 can't use this feature anymore:
https://github.com/pytorch/pytorch/blob/v1.7.0/torch/optim/optimizer.py#L167
But maybe not a big problem?

Thanks.

yes, 1.7a is actually some 1.6.x, btw looks like this flag is accurate:

if it doesn't work we change to "<=1.7"

/black

I think if there's no cyclic import, we can from monai.utils.module import PT_BEFORE_1_7 ?

I think if there's no cyclic import, we can from monai.utils.module import PT_BEFORE_1_7 ?

Sure, thanks for the suggestion, I didn't notice this global variable.

Thanks.

/black