Skip to content

2590 Add more pad args in ResizeWithPadOrCrop transform#2594

Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2590-enhance-padorcrop
Jul 14, 2021
Merged

2590 Add more pad args in ResizeWithPadOrCrop transform#2594
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2590-enhance-padorcrop

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 14, 2021

Fixes #2590 .

Description

This PR added more pad args in the ResizeWithPadOrCrop transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 14, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 14, 2021 02:37
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 14, 2021

This PR is based on user's feedback, it should be a follow-up PR of #2465.

Thanks.

yiheng-wang-nv
yiheng-wang-nv approved these changes Jul 14, 2021
View reviewed changes
@Nic-Ma Nic-Ma enabled auto-merge (squash) July 14, 2021 05:40
@Nic-Ma Nic-Ma merged commit ada5502 into Project-MONAI:dev Jul 14, 2021
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 14, 2021

Could you help review all the usage of spatialpad in the codebase for the same issue? It seems we are still missing a few

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 14, 2021

Hi @wyli ,

OK, let me try to add for all the places in the code base.

Thanks.

@Nic-Ma Nic-Ma mentioned this pull request Jul 14, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@wyli wyli Awaiting requested review from wyli

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nic-Ma @wyli @yiheng-wang-nv