2571 add DecollateBatch handler#2584
Merged
Nic-Ma merged 15 commits intoProject-MONAI:devfrom Jul 14, 2021
Merged
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
wyli
reviewed
Jul 13, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, I put suggestions of refactoring. while looking at the Decollated transform,
any idea why we don't allow for decollating a few user-specified keys? it might be useful for quickly decollating a few items from
data, if decollate_batch(rep_scalar_to_batch(...)) is not flexible enough for the users
Contributor
Author
|
/black |
Contributor
Author
|
Hi @wyli , Thanks for your review. Thanks in advance. |
Signed-off-by: Nic Ma <[email protected]>
wyli
approved these changes
Jul 13, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, these are non-breaking changes that improve flexibility.
Nic-Ma
force-pushed
the
2571-add-decollate-handler
branch
from
10c87d1 to
513519f
Compare
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
2571-add-decollate-handler
branch
from
513519f to
182df87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2571 .
Description
This PR added the
DecollateBatchhandler to provide a more flexible operation to decollate the batch.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.