Skip to content

Lmdb improvements#2578

Merged
Nic-Ma merged 3 commits intoProject-MONAI:devfrom
wyli:lmdb-improvements
Jul 13, 2021
Merged

Lmdb improvements#2578
Nic-Ma merged 3 commits intoProject-MONAI:devfrom
wyli:lmdb-improvements

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 12, 2021 •
edited
Loading

redo the previous lmdb improvements #2531

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title Lmdb improvements [WIP] Lmdb improvements Jul 12, 2021
wyli added 3 commits July 13, 2021 17:43
@wyli
update lmdbdataset (Project-MONAI#2531)
668e914 
* update lmdbdataset

Signed-off-by: Wenqi Li <[email protected]>

* update tests

Signed-off-by: Wenqi Li <[email protected]>

* docstring and less verbose progressbar

Signed-off-by: Wenqi Li <[email protected]>

* docstring

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes lmdb integration tests
c9da43b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
add docstring
c1224e6 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the lmdb-improvements branch from 32ea4be to c1224e6 Compare July 13, 2021 16:59
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 13, 2021

/integration-test

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 13, 2021

/build

@wyli wyli marked this pull request as ready for review July 13, 2021 21:17
@wyli wyli changed the title [WIP] Lmdb improvements Lmdb improvements Jul 13, 2021
@wyli wyli requested review from Nic-Ma, ericspod and rijobro and removed request for Nic-Ma July 13, 2021 21:17
Nic-Ma
Nic-Ma approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
Looks good to me.
Thanks.

@Nic-Ma Nic-Ma merged commit ab5eb63 into Project-MONAI:dev Jul 13, 2021
@wyli wyli deleted the lmdb-improvements branch November 16, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyli @Nic-Ma