Skip to content

2571 enhance decollate arg of workflows#2577

Merged
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:2571-enhance-decollate-arg
Jul 12, 2021
Merged

2571 enhance decollate arg of workflows#2577
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:2571-enhance-decollate-arg

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 12, 2021

Part of #2571

Description

This PR enhanced the decollate arg of workflows to provide more flexible usage.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 2571 enhance decollate arg of workflows 2571 enhance decollate arg of workflows Jul 12, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 12, 2021 16:42
@Nic-Ma Nic-Ma requested a review from wyli July 12, 2021 16:43
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the docstrings should make a recommendation, otherwise it looks good

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 12, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 12, 2021 23:10
@Nic-Ma Nic-Ma merged commit 9818467 into Project-MONAI:dev Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants