Skip to content

2556 Fix EnsureType test error in PyTorch 1.5.1#2558

Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2556-fix-ensuretype-test
Jul 8, 2021
Merged

2556 Fix EnsureType test error in PyTorch 1.5.1#2558
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2556-fix-ensuretype-test

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 8, 2021

Fixes #2556 .

Description

This PR fixed the CI test error of EnsureType transform on PyTorch 1.5.1.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 8, 2021

Hi @wyli ,

I verified the tests locally with PyTorch 1.5.1:

root@apt-sh-ai:/workspace/data/medical/MONAI# python
Python 3.8.5 (default, Sep  4 2020, 07:30:14)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> print(torch.__version__)
1.5.1
>>> exit()
root@apt-sh-ai:/workspace/data/medical/MONAI# python tests/test_ensure_type.py
......
----------------------------------------------------------------------
Ran 6 tests in 0.004s

OK
root@apt-sh-ai:/workspace/data/medical/MONAI# python tests/test_ensure_typed.py
......
----------------------------------------------------------------------
Ran 6 tests in 0.004s

OK

Could you please help review it?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 8, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 8, 2021 10:04
wyli
wyli approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 8, 2021 10:07
wyli
wyli reviewed Jul 8, 2021
View reviewed changes
@Nic-Ma Nic-Ma merged commit 66bc397 into Project-MONAI:dev Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cron test error -- test_ensure_typed

2 participants

@Nic-Ma @wyli