Skip to content

2541 adds whats new 0.6#2550

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:2541-whats-new
Jul 8, 2021
Merged

2541 adds whats new 0.6#2550
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:2541-whats-new

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 7, 2021 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #2541

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the 2541-whats-new branch from e8d5610 to 2d23843 Compare July 8, 2021 12:32
@wyli wyli marked this pull request as ready for review July 8, 2021 12:43
@wyli wyli requested a review from Nic-Ma July 8, 2021 12:43
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 8, 2021

Hi @Nic-Ma @yiheng-wang-nv, I'll tag 0.6 after merging this one. do you have any other pending PRs?

Nic-Ma
Nic-Ma reviewed Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a minor comment.

Thanks.

@wyli wyli force-pushed the 2541-whats-new branch from 4ef407b to e11c5a8 Compare July 8, 2021 14:38
@wyli wyli requested a review from Nic-Ma July 8, 2021 14:40
Nic-Ma
Nic-Ma approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 8, 2021

I think @yiheng-wang-nv and I don't have other pending PRs.
Please feel free to tag v0.6.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 8, 2021

/build

1 similar comment
@madil90
Copy link
Copy Markdown
Contributor

madil90 commented Jul 8, 2021

/build

wyli added 4 commits July 8, 2021 16:18
@wyli
adds whats new 0.6
cc452e3 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update docs
723b250 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
add a list
27d9585 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update according to comments
6f485bd 
Signed-off-by: Wenqi Li <[email protected]>
@madil90
Copy link
Copy Markdown
Contributor

madil90 commented Jul 8, 2021

/build

@wyli
fixes typos
a9119b3 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 2541-whats-new branch from e11c5a8 to a9119b3 Compare July 8, 2021 15:26
@wyli
Revert "update lmdbdataset (Project-MONAI#2531)"
81323e4 
This reverts commit a980ae4.

Signed-off-by: Wenqi Li <[email protected]>
@madil90
Copy link
Copy Markdown
Contributor

madil90 commented Jul 8, 2021

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 8, 2021

I think @yiheng-wang-nv and I don't have other pending PRs.
Please feel free to tag v0.6.

Thanks.

Hi @Nic-Ma, I reverted a980ae4, because the integration test failed. #2531 is not a critical feature, so let's postpone it to after v0.6.0

@wyli wyli merged commit 0ad9e73 into Project-MONAI:dev Jul 8, 2021
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 8, 2021

Hi @wyli ,

Sure, it's not a blocking issue I think.

Thanks.

@wyli wyli deleted the 2541-whats-new branch July 8, 2021 23:23
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 8, 2021

Hi @wyli ,

Sure, it's not a blocking issue I think.

Thanks.

thanks for confirming, then I'll release 0.6 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

adds a 'what's new in 0.6.0' page

3 participants

@wyli @Nic-Ma @madil90