Skip to content

2512 Make get_model_spec API#2515

Merged
Nic-Ma merged 3 commits intodevfrom
2512-enhance-load-mmar
Jul 3, 2021
Merged

2512 Make get_model_spec API#2515
Nic-Ma merged 3 commits intodevfrom
2512-enhance-load-mmar

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 2, 2021

Fixes #2512 .

Description

This PR makes get_model_spec as API according to the feature reuqest.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 2, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 2, 2021

Mark: I created branch in the main repo directly because there is some Github issue today that it is pending on loadings the branch list if creating a PR from a forked repo.
Will delete this branch immediately when merged.

Thanks.

Thanks.

@Nic-Ma Nic-Ma requested review from IsaacYangSLA and wyli July 2, 2021 23:53
@Nic-Ma Nic-Ma mentioned this pull request Jul 2, 2021
Closed
Nic-Ma added 2 commits July 3, 2021 08:09
@Nic-Ma Nic-Ma enabled auto-merge (squash) July 3, 2021 01:13
@Nic-Ma Nic-Ma merged commit f3d436a into dev Jul 3, 2021
@Nic-Ma Nic-Ma deleted the 2512-enhance-load-mmar branch July 3, 2021 01:58
wyli pushed a commit to wyli/MONAI that referenced this pull request Jul 5, 2021
@Nic-Ma @wyli
2512 Make get_model_spec API (Project-MONAI#2515)
c39edcf 
* [DLMED] make get_model_spec API

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] unit tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add utility to be able to retrieve MMAR ts/pt relative path from MMAR model id

2 participants

@Nic-Ma @IsaacYangSLA