Skip to content

2500 upgrade to use 21.06 base image#2501

Merged
Nic-Ma merged 7 commits intodevfrom
test-2106
Jul 2, 2021
Merged

2500 upgrade to use 21.06 base image#2501
Nic-Ma merged 7 commits intodevfrom
test-2106

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 1, 2021

Fixes #2500

Description

base image upgrade
tested:

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

wyli added 6 commits July 1, 2021 15:14
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
This reverts commit f5385c2.

Signed-off-by: Wenqi Li <[email protected]>
This reverts commit 4468dcc.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from Nic-Ma July 1, 2021 14:18
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 1, 2021

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 1, 2021

Hi @wyli ,

Do you know why /integration-test can't work in this PR?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 1, 2021

Hi @wyli ,

Do you know why /integration-test can't work in this PR?

Thanks.

the failure is because of #2502, let me merge the fix in #2503 first

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 1, 2021

/integration-test

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 2, 2021

This passes the integration and was tested https://github.com/Project-MONAI/MONAI/actions/runs/988017864, is there any other concern? @Nic-Ma

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Nic-Ma Nic-Ma merged commit b082456 into dev Jul 2, 2021
@Nic-Ma Nic-Ma deleted the test-2106 branch July 2, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade base image to pytorch 21.06

2 participants