Skip to content

2495 Enhance PatchEmbeddingBlock#2496

Merged
wyli merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:2495-enhance-net-block
Jul 1, 2021
Merged

2495 Enhance PatchEmbeddingBlock#2496
wyli merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:2495-enhance-net-block

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 1, 2021 •
edited
Loading

partly fixes issue 2495 .

Description

This PR enhanced the PatchEmbeddingBlock to fix CI tests and fixed wrong data type, removed unused args.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

/black

Nic-Ma added 3 commits July 1, 2021 17:33
@Nic-Ma
[DLMED] fix vit
301e581 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] update docs
7e279e6 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] fix UNetr
055bcaa 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

/black

@Nic-Ma Nic-Ma changed the title [WIP] 2495 Enhance PatchEmbeddingBlock 2495 Enhance PatchEmbeddingBlock Jul 1, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 1, 2021 09:43
@Nic-Ma Nic-Ma mentioned this pull request Jul 1, 2021
Closed
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021 •
edited
Loading

Hi @wyli ,

There is only 1 change is really related to the code, I removed the classification arg of PatchEmbeddingBlock as it's not used in PatchEmbeddingBlock at all.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 1, 2021

Could you please help confirm the changes in this PR? @ahatamiz

ahatamiz
ahatamiz approved these changes Jul 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahatamiz ahatamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes look nice.

@ahatamiz
Copy link
Copy Markdown
Contributor

ahatamiz commented Jul 1, 2021

Could you please help confirm the changes in this PR? @ahatamiz

Just reviewed. Everything looks good.

@wyli wyli merged commit 315c585 into Project-MONAI:dev Jul 1, 2021
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 1, 2021

Thanks @ahatamiz. Hi @Nic-Ma why is this partly fixing #2495? could you please document the missing parts?

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

Hi @wyli ,

I didn't check every line of UNETR related logic, so I marked as "partly". I will try to double confirm ASAP later.

Thanks.

@Nic-Ma Nic-Ma deleted the 2495-enhance-net-block branch July 2, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@wyli wyli Awaiting requested review from wyli

+1 more reviewer

@ahatamiz ahatamiz ahatamiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nic-Ma @wyli @ahatamiz @yiheng-wang-nv