Skip to content

2468 Add ignite dist to support more backends#2492

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:2468-more-dist-backends
Jul 2, 2021
Merged

2468 Add ignite dist to support more backends#2492
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:2468-more-dist-backends

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 1, 2021

Fixes #2468 .

Description

This PR added dist implementation based on ignite APIs to support more kinds of backends.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the 2468-more-dist-backends branch from 16125ed to 811c736 Compare July 1, 2021 04:03
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 1, 2021 04:31
@Nic-Ma
[DLMED] fix typo
0239a24 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

Hi @wyli ,

As we don't have Horovod, XLA, etc. in the dist CI tests, I locally tested both PyTorch and ignite implementation based on the native GLOO and NCCL backends.

Thanks.

This was referenced Jul 1, 2021
Closed
Merged
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 1, 2021

/black

@Nic-Ma Nic-Ma requested a review from vfdev-5 July 1, 2021 14:48
vfdev-5
vfdev-5 reviewed Jul 1, 2021
View reviewed changes
wyli
wyli reviewed Jul 1, 2021
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 2, 2021

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 2, 2021 •
edited
Loading

/integration-test

wyli
wyli approved these changes Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 2, 2021 09:18
@wyli wyli disabled auto-merge July 2, 2021 09:21
@wyli wyli enabled auto-merge (squash) July 2, 2021 11:13
@wyli wyli merged commit 321d65b into Project-MONAI:dev Jul 2, 2021
@Nic-Ma Nic-Ma deleted the 2468-more-dist-backends branch July 2, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support more backends in distributed operations

4 participants

@Nic-Ma @wyli @vfdev-5 @monai-bot