Deprecated fix#2482
Merged
ericspod merged 7 commits intoProject-MONAI:devfrom Jun 29, 2021
ericspod:deprecated_fix
Merged
Conversation
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
wyli
reviewed
Jun 29, 2021
| def _try_cast(val): | ||
| val = val.strip() | ||
| try: | ||
| m = re.match("(\\d+)(.*)", val) |
Contributor
There was a problem hiding this comment.
we should prefer optional_import("pkg_resources", name="parse_version") if it is installed... this version_leq will be used in many cases, better to make it as robust as possible
wyli
approved these changes
Jun 29, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! if you don't have time to add optional_import("pkg_resources", name="parse_version"), I'll do it later today
Signed-off-by: Eric Kerfoot <[email protected]>
7 tasks
Member
Author
|
This should sort the optional dependency on pkg_resources now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Kerfoot [email protected]
Fixes #2479 .
Description
This fixes an issue with version strings and replaces some functionality reliant on an optional package with an internal solution. Version strings should contain integers separated by ".", any component not containing an integer is broken into an initial integer component and the rest. The integers from this are compared when comparing versions, so "0.6.0rc0" will be treated the same as "0.6.0". Git version suffixes are ignored.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.