Skip to content

2273 update model items#2473

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:2273-update-models
Jun 29, 2021
Merged

2273 update model items#2473
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:2273-update-models

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 28, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2273

Description

  • tested all MMAR models
  • using _get_ngc_url API instead of hard-coded URL
  • using _get_ngc_doc_url API instead of hard-coded DOC

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and holgerroth June 28, 2021 20:36
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 28, 2021

Hi @Nic-Ma these are all tested with the commands:

from monai.apps.mmars import MODEL_DESC, load_from_mmar

for idx, item_x in enumerate(MODEL_DESC):
    print(idx)
    load_from_mmar(item_x, mmar_dir="./temp", map_location="cpu")

All the 16 NGC models (named 'clara_pt_*') are included.
Thanks!

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update!

@Nic-Ma Nic-Ma requested a review from IsaacYangSLA June 29, 2021 00:25
@wyli wyli merged commit f831c7f into Project-MONAI:dev Jun 29, 2021
@wyli wyli deleted the 2273-update-models branch June 29, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APIs to load pretrained models from Clara Train 4.0 (6/July)

2 participants