Skip to content

2445 Fix inplace modification issue of SmartCacheDataset#2446

Merged
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:fix-inplace-shuffle-smartcache
Jun 25, 2021
Merged

2445 Fix inplace modification issue of SmartCacheDataset#2446
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:fix-inplace-shuffle-smartcache

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 25, 2021

Fixes #2445 .

Description

This PR fixed the issue that SmartCacheDataset modified the original input data list.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 25, 2021

/black

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma enabled auto-merge (squash) June 25, 2021 04:36
@Nic-Ma Nic-Ma merged commit eec33b6 into Project-MONAI:dev Jun 25, 2021
@Nic-Ma Nic-Ma deleted the fix-inplace-shuffle-smartcache branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartCacheDataset modified input datalist

2 participants