Skip to content

no need for default orig_size stored for invertible transforms#2441

Merged
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:fix_inverse_orig_size
Jun 25, 2021
Merged

no need for default orig_size stored for invertible transforms#2441
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:fix_inverse_orig_size

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jun 24, 2021

Description

If an object didn't have the attribute shape, we stored orig_size as None. However, None can't be collated into a batch, so if the object doesn't have the attribute shape, then don't store that information.

Fixes #2414.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

@rijobro rijobro requested review from Nic-Ma and wyli June 24, 2021 16:38
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro changed the title default orig_size None -> -1 no need for default orig_size stored for invertible transforms Jun 24, 2021
@rijobro rijobro enabled auto-merge (squash) June 24, 2021 18:35
@rijobro rijobro merged commit 6401c5e into Project-MONAI:dev Jun 25, 2021
@rijobro rijobro deleted the fix_inverse_orig_size branch May 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants