Skip to content

2428 Enhance docs for pure PyTorch loss, optimizer, etc#2429

Merged
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:2428-enhance-docs
Jun 23, 2021
Merged

2428 Enhance docs for pure PyTorch loss, optimizer, etc#2429
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:2428-enhance-docs

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 23, 2021

Fixes #2428 .

Description

This PR enhanced the docs to make it clear that MONAI loss, optimizer just follow the regular pure PyTorch pattern and MONAI workflows work with pure PyTorch components.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 23, 2021 17:13
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 23, 2021 17:16
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma force-pushed the 2428-enhance-docs branch from 2d95fc0 to 5bc8c51 Compare June 23, 2021 17:18
@Nic-Ma Nic-Ma merged commit c20f70b into Project-MONAI:dev Jun 23, 2021
@Nic-Ma Nic-Ma deleted the 2428-enhance-docs branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance technical highlights for the pure PyTorch components

2 participants