Skip to content

2407 Add support to set number classes for TorchVision models#2408

Merged
wyli merged 24 commits intoProject-MONAI:devfrom
Nic-Ma:2407-add-torchvision-class
Jun 24, 2021
Merged

2407 Add support to set number classes for TorchVision models#2408
wyli merged 24 commits intoProject-MONAI:devfrom
Nic-Ma:2407-add-torchvision-class

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 22, 2021 •
edited
Loading

Fixes #2407 .

Description

This PR added the wrapper class to finetune 2D classification models, support to change the output classes of FC layer.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 22, 2021

/black

@Nic-Ma Nic-Ma changed the title [WIP] 2407 Add support to set number classes for TorchVision models 2407 Add support to set number classes for TorchVision models Jun 22, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review June 22, 2021 14:37
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 22, 2021 14:38
@Nic-Ma Nic-Ma force-pushed the 2407-add-torchvision-class branch from 506ce60 to a8296a7 Compare June 22, 2021 14:43
wyli
wyli reviewed Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I put some comments inline

@Nic-Ma Nic-Ma requested a review from wyli June 23, 2021 13:02
@Nic-Ma Nic-Ma force-pushed the 2407-add-torchvision-class branch from 21dd99e to 56c9ff9 Compare June 23, 2021 13:04
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021 •
edited
Loading

Hi @wyli ,

Thanks for your great suggestions, I updated the PR based on your comments and added more unit tests to cover.
Could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

/black

wyli
wyli reviewed Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please see some comments inline

wyli
wyli reviewed Jun 23, 2021
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

Hi @wyli ,

Thanks for your cool suggestions.
I updated this PR according to your comments.
Could you please help review it again?

Thanks.

@Nic-Ma Nic-Ma disabled auto-merge June 23, 2021 17:19
wyli
wyli reviewed Jun 23, 2021
View reviewed changes
wyli
wyli reviewed Jun 23, 2021
View reviewed changes
@wyli wyli dismissed their stale review June 23, 2021 19:55

Need integration tests.for the mmar

wyli
wyli reviewed Jun 23, 2021
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 23, 2021

Hi @wyli ,

Thanks for pointing out the potential issue, I updated the PR according to your comments.
Could you please help review it again?

Thanks in advance.

monai-bot and others added 2 commits June 23, 2021 23:46
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 24, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 24, 2021

/integration-test

@Nic-Ma Nic-Ma requested a review from wyli June 24, 2021 00:33
wyli
wyli reviewed Jun 24, 2021
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 24, 2021

/black

wyli
wyli reviewed Jun 24, 2021
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 24, 2021

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 24, 2021

/integration-test

Hi @wyli ,

It seems that integration tests can not be triggered today, something related to the new Blossom CI?

Thanks.

@wyli wyli enabled auto-merge (squash) June 24, 2021 16:09
@wyli wyli merged commit 79b83d9 into Project-MONAI:dev Jun 24, 2021
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 24, 2021 •
edited
Loading

/integration-test

Hi @wyli ,

It seems that integration tests can not be triggered today, something related to the new Blossom CI?

Thanks.

I think @IsaacYangSLA resolved the integration issue by adding a missing package to requirements-dev.txt yesterday.
@IsaacYangSLA please feel free to correct me if I misunderstood anything.

Thanks for the quick fix!

@Nic-Ma Nic-Ma deleted the 2407-add-torchvision-class branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to change class number of TorchVision models

3 participants

@Nic-Ma @wyli @monai-bot