Skip to content

Add min tests cmd to runtests script#2400

Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:add-min-tests-cmd
Jun 22, 2021
Merged

Add min tests cmd to runtests script#2400
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:add-min-tests-cmd

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 21, 2021

Description

This PR added the min command to runtests.sh script, to run it in the same way as other tests.
Non-breaking enhancement for the local test.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 21, 2021 12:20
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2021

/black

wyli
wyli approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to ensure it's running with the min. environment

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2021 •
edited
Loading

not sure how to ensure it's running with the min. environment

Good question, let me try to change the CI script of min to use runtests.sh to test it.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2021

Hi @wyli ,

When I try to update the CI config, I got an error:

nma@apt-sh-ai:~/WorkSpace/Deep_Learning/Clara_SDK/medical/MONAI$ git push origin HEAD
Username for 'https://github.com': Nic-Ma
Password for 'https://[email protected]': 
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 24 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 472 bytes | 472.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To https://github.com/Nic-Ma/MONAI.git
 ! [remote rejected]   HEAD -> add-min-tests-cmd (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/pythonapp.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/Nic-Ma/MONAI.git'

Should I apply for some permission?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 21, 2021

I think the error 'refusing to allow a Personal Access Token to create or update workflow .github/workflows/pythonapp.yml without workflow scope' is because you didn't create your github token with this permission

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2021

Hi @wyli ,

Cool, thanks for your help!

@Nic-Ma Nic-Ma force-pushed the add-min-tests-cmd branch from 59aa177 to ed7d624 Compare June 21, 2021 16:00
@Nic-Ma Nic-Ma enabled auto-merge (squash) June 21, 2021 16:03
@Nic-Ma Nic-Ma merged commit 8cda6c1 into Project-MONAI:dev Jun 22, 2021
@Nic-Ma Nic-Ma deleted the add-min-tests-cmd branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nic-Ma @wyli