Skip to content

2369 Add missing arg detach to Decollated and InverseBatchTransform#2393

Merged
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:2369-add-detach-arg
Jun 18, 2021
Merged

2369 Add missing arg detach to Decollated and InverseBatchTransform#2393
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma:2369-add-detach-arg

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 18, 2021

Fixes #2369 .

Description

Follow up of #2378 , this PR added the missing arg detach to Decollated transform and InverseBatchTransform, and added to unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 18, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 18, 2021 12:05
@Nic-Ma Nic-Ma enabled auto-merge (squash) June 18, 2021 12:42
@Nic-Ma Nic-Ma merged commit f3f9584 into Project-MONAI:dev Jun 18, 2021
@Nic-Ma Nic-Ma deleted the 2369-add-detach-arg branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should detach the Tensor before decollate_batch

2 participants