Skip to content

Update crop and pad doc-strings for the ROI size#2389

Merged
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:update-crop-doc-string
Jun 18, 2021
Merged

Update crop and pad doc-strings for the ROI size#2389
Nic-Ma merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:update-crop-doc-string

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 18, 2021

Description

According to the feedback from Yucheng(our internal team), this PR enhanced the doc-strings of all the pad and crop transforms to make it clear about the output data size.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 18, 2021

/black

Nic-Ma added 2 commits June 18, 2021 13:47
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma enabled auto-merge (squash) June 18, 2021 06:06
@Nic-Ma Nic-Ma merged commit b2e7fd4 into Project-MONAI:dev Jun 18, 2021
@Nic-Ma Nic-Ma deleted the update-crop-doc-string branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants