2369 Detach Tensor in decollate_batch#2378
Closed
Nic-Ma wants to merge 6 commits intoProject-MONAI:devfrom
Closed
Conversation
Nic-Ma
force-pushed
the
2369-detach-tensor
branch
from
1d3084b to
4bd3d05
Compare
Contributor
Author
|
/black |
Contributor
|
I think we should work on a generic decollate utility like #2379, the current implementation is becoming difficult to maintain |
Contributor
Author
Yes, thanks for your refactoring, let's close this PR and complete your PR directly. Thanks. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2369 .
Description
This PR enhanced the
decollate_batchAPI to detach tensors and added several sanity checks.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.