2360 Enhance the data type of GradCam#2368
Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom Jun 15, 2021
Merged
Conversation
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
wyli
reviewed
Jun 15, 2021
Signed-off-by: Nic Ma <[email protected]>
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Jun 16, 2021
* [DLMED] enhance GradCam return type Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> Co-authored-by: monai-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2360 .
Description
This PR enhanced the return data type/device of
GradCamto be consistent with input data.It follows the regular usages in user's feedback and our tutorial:
https://github.com/Project-MONAI/tutorials/blob/master/modules/interpretability/covid_classification.ipynb
And it's also consistent with our new feature that updates all the transforms to support input/output Tensor data.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.