Skip to content

2345 no default mmar home for pytorch < 1.6#2346

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:2345-default-mmar-dir
Jun 9, 2021
Merged

2345 no default mmar home for pytorch < 1.6#2346
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:2345-default-mmar-dir

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 9, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2345

Description

the get_dir API is not available for pytorch < 1.6,
in this case, the user should provide a directory or upgrade pytorch

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

@wyli wyli requested review from Nic-Ma and ericspod June 9, 2021 09:21
wyli added 2 commits June 9, 2021 13:55
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 2345-default-mmar-dir branch from 476482d to fc11019 Compare June 9, 2021 12:56
@wyli wyli enabled auto-merge (squash) June 9, 2021 12:58
@wyli wyli merged commit cbf2521 into Project-MONAI:dev Jun 9, 2021
@wyli wyli deleted the 2345-default-mmar-dir branch June 30, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

module 'torch.hub' has no attribute 'get_dir' in pytorch 1.5

2 participants