Skip to content

Fixes mypy issue#2340

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:fixes-mypy
Jun 9, 2021
Merged

Fixes mypy issue#2340
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:fixes-mypy

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 8, 2021

Fixes https://github.com/Project-MONAI/MONAI/runs/2778490290?check_suite_focus=true#step:7:345

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

wyli added 5 commits June 8, 2021 23:49
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
This reverts commit da85539.

Signed-off-by: Wenqi Li <[email protected]>
This reverts commit 2651b55.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and madil90 June 8, 2021 22:54
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 8, 2021

@wyli wyli requested a review from ericspod June 8, 2021 22:57
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Thanks for your quick fix.
May I know the root cause of this issue?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 8, 2021

because mypy 0.9 introduced some changes...

@wyli wyli enabled auto-merge (squash) June 8, 2021 23:01
@wyli wyli merged commit 6476cee into Project-MONAI:dev Jun 9, 2021
@wyli wyli deleted the fixes-mypy branch June 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants