Skip to content

2333 conditionally install pytype#2334

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:2333-update-requirements
Jun 8, 2021
Merged

2333 conditionally install pytype#2334
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:2333-update-requirements

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 8, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2333

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

@wyli wyli marked this pull request as draft June 8, 2021 12:20
wyli added 2 commits June 8, 2021 13:38
@wyli wyli force-pushed the 2333-update-requirements branch from 88c02b9 to 9c6b0d4 Compare June 8, 2021 12:38
@wyli wyli marked this pull request as ready for review June 8, 2021 13:11
@wyli wyli requested review from Nic-Ma and ericspod June 8, 2021 13:11
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Maybe @madil90 can help review more details.

Thanks.

@Nic-Ma Nic-Ma requested a review from madil90 June 8, 2021 16:04
@wyli wyli enabled auto-merge (squash) June 8, 2021 16:36
@wyli wyli merged commit a536462 into Project-MONAI:dev Jun 8, 2021
@wyli wyli deleted the 2333-update-requirements branch June 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pytype doesn't support windows

2 participants