Skip to content

2316 load image with big-endian header#2325

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:2316-nifti-header-big-endian
Jun 7, 2021
Merged

2316 load image with big-endian header#2325
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:2316-nifti-header-big-endian

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 7, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2316

Description

  • from big-endian to little-endian requires swapping the bytes, otherwise the header info are incorrect and may cause OOM

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma and rijobro June 7, 2021 12:39
@wyli wyli changed the title fixes 2316 load image with big-endian header 2316 load image with big-endian header Jun 7, 2021
@wyli wyli force-pushed the 2316-nifti-header-big-endian branch from 0234d2d to 1f53e56 Compare June 7, 2021 14:05
wyli added 3 commits June 7, 2021 16:04
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 2316-nifti-header-big-endian branch from 1f53e56 to 415ea76 Compare June 7, 2021 15:04
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) June 7, 2021 15:09
@wyli wyli merged commit a5376df into Project-MONAI:dev Jun 7, 2021
@wyli wyli deleted the 2316-nifti-header-big-endian branch June 8, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving NiFTI images with resampling raises memory error

2 participants