Skip to content

2316 Make saved affine match data content#2322

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2316-fix-resample-affine
Jun 7, 2021
Merged

2316 Make saved affine match data content#2322
wyli merged 6 commits intoProject-MONAI:devfrom
Nic-Ma:2316-fix-resample-affine

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 7, 2021

Fixes #2316 .

Description

This PR fixed an issue that if only updating orientation by don't resample, the saved affine doesn't match data content.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 7, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 7, 2021

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 7, 2021

/integration-test

@wyli wyli merged commit 27e64e0 into Project-MONAI:dev Jun 7, 2021
@Nic-Ma Nic-Ma deleted the 2316-fix-resample-affine branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving NiFTI images with resampling raises memory error

2 participants