2220 Decollate batch into list after iteration computation (29/June)#2315
Merged
2220 Decollate batch into list after iteration computation (29/June)#2315
Conversation
…2244) * [DLMED] add support for Activation transform Signed-off-by: Nic Ma <[email protected]> * [DLMED] change all the array level post transforms to channel-first Signed-off-by: Nic Ma <[email protected]> * [DLMED] update all the IO, utility, post transforms Signed-off-by: Nic Ma <[email protected]> * [DLMED] update engines for list of dict Signed-off-by: Nic Ma <[email protected]> * [DLMED] update all the event handlers Signed-off-by: Nic Ma <[email protected]> * [DLMED] support non-batch data Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> * [DLMED] update based on the latest APIs Signed-off-by: Nic Ma <[email protected]> Co-authored-by: monai-bot <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
feature/2220-decollate
branch
from
6889e1c to
b86b921
Compare
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
feature/2220-decollate
branch
from
b86b921 to
fb3ce3e
Compare
Nic-Ma
changed the title
Contributor
Author
|
/black |
Contributor
Author
|
/integration-test |
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Nic-Ma
changed the title
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Mark: when PR #2451 merged, I will update the integration test in this PR that computes a list tensors in ignite metrics. Thanks. |
wyli
reviewed
Jun 28, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, please see some comments inline
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @wyli , I updated the integration test to use ignite v0.4.5 metrics, hopefully, it will work when the ignite 0.4.5 PR merged. Thanks. |
Contributor
sure, I'll run all the nightly tests on this branch before merging |
Contributor
Author
|
Thanks, let me fix all the merge conflicts. |
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
Hi @wyli , Thanks for your quick fix in CI config, added the issue to this PR description. |
wyli
approved these changes
Jun 29, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! I did my best to review this PR, and all the CI pipelines seem to be happy with it.
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2220 #2300 #2275 #2410 #2452 .
Description
This PR added support to decollate the iteration output.
The main idea is to decollate the output dict / list of an iteration into a list of dicts / lists, copy the scalar values(like loss) into every dict / list. then all the following logic are based on this list of dicts / lists.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.