Skip to content

573 masked loss wrapper#2313

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:masked-loss-wrapper
Jun 7, 2021
Merged

573 masked loss wrapper#2313
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:masked-loss-wrapper

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 5, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #573

Description

adds a generic loss masking class

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli changed the title masked loss wrapper 573 masked loss wrapper Jun 5, 2021
@wyli wyli force-pushed the masked-loss-wrapper branch from c467c3c to 96de2f6 Compare June 5, 2021 21:27
@wyli wyli marked this pull request as ready for review June 5, 2021 21:42
@wyli wyli force-pushed the masked-loss-wrapper branch from 5f4f867 to 05c51fb Compare June 5, 2021 21:48
@wyli wyli marked this pull request as draft June 5, 2021 23:11
@wyli wyli force-pushed the masked-loss-wrapper branch from 5fdecb2 to c2ea5ac Compare June 5, 2021 23:35
@wyli wyli marked this pull request as ready for review June 7, 2021 15:07
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't see any mistakes here.

wyli added 3 commits June 7, 2021 16:49
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the masked-loss-wrapper branch 3 times, most recently from 247f77f to ac63135 Compare June 7, 2021 15:55
@wyli wyli enabled auto-merge (squash) June 7, 2021 20:40
@wyli wyli merged commit 1fa03c2 into Project-MONAI:dev Jun 7, 2021
@wyli wyli deleted the masked-loss-wrapper branch June 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a loss mask?

2 participants