2056 additional deepgrow workflow events#2305
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Jun 4, 2021
Merged
Conversation
wyli
changed the title
Nic-Ma
reviewed
Jun 4, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for your quick PR.
I put some comments for a minor issue, others look good to me.
Thanks.
wyli
force-pushed
the
2056-additional-events
branch
from
ac0488c to
e6eda36
Compare
Contributor
Author
|
the |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
2056-additional-events
branch
from
e6eda36 to
649fa30
Compare
Nic-Ma
approved these changes
Jun 4, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for your quick update.
Looks good to me now.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #2056
Description
this PR adds two new events to IterationEvents, which are useful for advanced workflows and debugging.
it's tested with the deepgrow workflow
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.