Skip to content

Move IterationEvents into workflow#2299

Merged
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-engines
Jun 3, 2021
Merged

Move IterationEvents into workflow#2299
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-engines

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 3, 2021

Description

This PR moved the IterationEvents registration into Workflow as we need to register decollate logic to IterationEvents.MODEL_COMPLETED event.
It also helped to remove several duplicated logic.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 3, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 3, 2021 04:21
@Nic-Ma Nic-Ma merged commit 63a3c78 into Project-MONAI:dev Jun 3, 2021
@Nic-Ma Nic-Ma deleted the adjust-engines branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants