Skip to content

Use reshape to replace view in loss function#2298

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:2296-fix-focal-loss
Jun 3, 2021
Merged

Use reshape to replace view in loss function#2298
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:2296-fix-focal-loss

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Fixes #2296 .

Description

Use reshape to replace view in class FocalLoss and GeneralizedWassersteinDiceLoss.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma June 3, 2021 03:49
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) June 3, 2021 10:40
@wyli wyli merged commit 4defcdf into Project-MONAI:dev Jun 3, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the 2296-fix-focal-loss branch July 2, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FocalLoss Runtime Error (view() instead of reshape())

2 participants