Skip to content

2273 initial MMAR model download and extract#2297

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:2273-load-clara-train-model
Jun 7, 2021
Merged

2273 initial MMAR model download and extract#2297
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:2273-load-clara-train-model

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 2, 2021

Signed-off-by: Wenqi Li [email protected]

part of #2273

Description

providing MMAR downloading and parsing functions

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma and yiheng-wang-nv June 2, 2021 20:12
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 2, 2021

/integration-test

@wyli wyli force-pushed the 2273-load-clara-train-model branch 4 times, most recently from c8721d1 to 197e651 Compare June 3, 2021 00:06
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick PR!
Let discuss this topic in the internal meeting based on this PR today.

Thanks.

@wyli wyli force-pushed the 2273-load-clara-train-model branch 2 times, most recently from d400b4d to dd27ec4 Compare June 3, 2021 16:27
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jun 4, 2021

Hi @yiheng-wang-nv ,

Could you please help review this PR?
When the design is ready, let's work together with Wenqi to enable all the MMARs for MONAI pre-trained weights.

Thanks.

@wyli wyli force-pushed the 2273-load-clara-train-model branch 2 times, most recently from c6cddd6 to e711c93 Compare June 4, 2021 07:39
@wyli wyli force-pushed the 2273-load-clara-train-model branch from e711c93 to 2d704c0 Compare June 4, 2021 07:43
@wyli wyli requested a review from Nic-Ma June 7, 2021 15:18
@wyli wyli enabled auto-merge (squash) June 7, 2021 16:38
@wyli wyli merged commit c208780 into Project-MONAI:dev Jun 7, 2021
@wyli wyli deleted the 2273-load-clara-train-model branch June 23, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants